Solution of the challenge #5675
Conversation
There was a problem hiding this comment.
Great job on your submission! 🎉 Your code is well-structured and meets most of the task requirements. Here are a few points to consider for improvement:
- CSS Variable Typo: There's a small typo in the CSS variable
--header-heigth. It should be corrected to--header-heightfor consistency and to avoid potential issues. data-qaAttribute: Thedata-qaattribute is typically used for testing. Ensure it's necessary for your project, and if not, consider removing it to keep your markup clean.- Alt Attribute for Logo: The alt attribute for the logo image should be more descriptive to enhance accessibility. Instead of just "logo," provide a specific description of the image content.
These adjustments will help improve the quality and maintainability of your code. Keep up the great work, and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <a | ||
| class="nav__link" | ||
| data-qa="hover" |
There was a problem hiding this comment.
The data-qa attribute is used here, which is typically for testing purposes. Ensure that this attribute is necessary and used consistently across your project if it's part of your testing strategy. If not, consider removing it to keep the markup clean.
| } | ||
|
|
||
| html { | ||
| --header-heigth: 60px; |
There was a problem hiding this comment.
There is a typo in the CSS variable --header-heigth. It should be --header-height to ensure consistency and avoid confusion.
No description provided.