Develop #5678
Develop #5678
Conversation
Yevhenia-S
commented
Nov 12, 2024
Yevhenia-S
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While your code is mostly on point, there are a couple of critical issues that need to be addressed before we can approve the pull request. The missing closing tag for the <link> element can lead to rendering issues, and the generic :hover selector might unintentionally affect other elements. Please fix these to ensure the functionality and maintainability of your code. Once these are resolved, you'll be all set! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| rel="preconnect" | ||
| href="https://fonts.gstatic.com" | ||
| /> | ||
|
|
There was a problem hiding this comment.
There is a missing closing tag for the <link> element. Ensure that all <link> tags are properly closed with a /> to maintain valid HTML syntax.
src/style.css
Outdated
| margin-left: 0; | ||
| } | ||
|
|
||
| :hover { |
There was a problem hiding this comment.
The :hover selector is too generic and might apply to unintended elements. Consider specifying the element it should apply to, such as .nav-link:hover, to avoid unexpected styling changes.
src/index.html
Outdated
| </a> | ||
| <nav> |
There was a problem hiding this comment.
| </a> | |
| <nav> | |
| </a> | |
| <nav class="nav"> |
src/index.html
Outdated
| </a> | ||
| <nav> | ||
| <ul class="nav-list"> | ||
| <li> |
There was a problem hiding this comment.
| <li> | |
| <li class="nav-item"> |
src/index.html
Outdated
| </li> | ||
| <li> |
There was a problem hiding this comment.
Add the blank line between the links
| </li> | |
| <li> | |
| </li> | |
| <li> |
src/style.css
Outdated
| font-family: Roboto, serif; | ||
| font-weight: 500; | ||
| font-style: normal; | ||
| background-color: darkblue; |
There was a problem hiding this comment.
Redundant
| background-color: darkblue; |
| font-family: Roboto, serif; | ||
| font-weight: 500; | ||
| font-style: normal; |
There was a problem hiding this comment.
Move font styles to the html selector
src/style.css
Outdated
| } | ||
|
|
||
| .nav-link:hover { | ||
| color: #00acdc; |
There was a problem hiding this comment.
Create a variable for repeated color and use it everywhere
