add task solution #3669
Open
add task solution #3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-mirzoian
suggested changes
Oct 16, 2023
src/index.html
Outdated
Comment on lines
14
to
27
| <form class="search-form" | ||
| data-qa="big"> | ||
| <input class="search-input big-form" | ||
| data-qa="keypress" | ||
| type="text" | ||
| placeholder="Try "Los Angeles""> | ||
| </form> | ||
|
|
||
| <form class="search-form" | ||
| data-qa="small"> | ||
| <input class="search-input small-form" | ||
| type="text" | ||
| placeholder="Try "Los Angeles""> | ||
| </form> |
And678
suggested changes
Oct 16, 2023
Comment on lines
+15
to
+19
| class="search-form" | ||
| data-qa="big" | ||
| > | ||
| <input | ||
| class="search-input big-form" |
There was a problem hiding this comment.
Use BEM classes for styling, e.g .search, .search__input, .search--big
polosanya
approved these changes
Oct 17, 2023
Comment on lines
+35
to
37
| </form> | ||
|
|
||
| </body> |
There was a problem hiding this comment.
Suggested change
| </form> | |
| </body> | |
| </form> | |
| </body> |
Don't leave empty lines between parent and child elements
Comment on lines
+43
to
+57
| .big-form { | ||
| height: 70px; | ||
| background: var(--big-search-icon); | ||
| padding-left: 62px; | ||
| font-family: inherit; | ||
| font-size: var(--big-form-font); | ||
| } | ||
|
|
||
| .small-form { | ||
| height: 42px; | ||
| font-family: inherit; | ||
| padding-left: 33px; | ||
| background: var(--small-search-icon); | ||
| font-size: var(--small-form-font); | ||
| background-size: var(--small-background-size); |
There was a problem hiding this comment.
You could make small/big form be the default one and add a modifier only to another
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.