Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4591

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #4591

wants to merge 1 commit into from

Conversation

mtereshyn
Copy link

  • Icon implemented using background-image CSS property
  • Inputs are written inside of 'form' tag with correctly passed attributes
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 Your code is well-structured and meets most of the task requirements. There are a few minor issues, such as the font-weight not matching the requirement, the incorrect data-qa attribute for the small search form input, missing spacing between search bars, and the absence of fallback fonts. These don't critically impact the functionality, so I'm approving your PR. Keep up the good work, and consider addressing these points to enhance your code quality even further! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants