Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font issue #4675

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Font issue #4675

wants to merge 3 commits into from

Conversation

AQingZeo
Copy link

  • Icon implemented using background-image CSS property
  • Inputs are written inside of 'form' tag with correctly passed attributes
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Comment:

Cannot find the exact font shown in the Figma file.
Figma shows Avenir, I tried Avenir and Avenir light but neither is the same as the reference in the test images.

src/style.css Outdated
Comment on lines 2 to 6
@font-face {
font-family: Avenir;
font-weight: 300;
src: url(https://github.com/platanus/fonts/blob/master/Avenir/Avenir-Light.woff);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@font-face {
font-family: Avenir;
font-weight: 300;
src: url(https://github.com/platanus/fonts/blob/master/Avenir/Avenir-Light.woff);
}
@font-face {
font-family: Avenir;
src: url('fonts/Avenir-Book.ttf') format('truetype');
font-weight: normal;
font-style: normal;
}
@font-face {
font-family: Avenir;
src: url('fonts/Avenir-Heavy.ttf') format('truetype');
font-weight: bold;
font-style: normal;
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants