-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New example app: visualize structure relaxation #323
Conversation
I agree, this is useful. Could be added to the TaskDocument component in #313 even. I will say that the longer-term goal was to support this via a This would be a lot faster, since geometries etc. are generated just once, and then it loops through a set of displacements, so it becomes much more responsive. However, in the interim, I think this solution is great--it works today! so in that sense it is the best solution :) |
Good idea! Are there some preliminary screenshots of the
I was thinking about that as well. Definitely makes sense. This PR constructs a list of structures one for each step which is needlessly expensive. |
clean up code and styles
@janosh yes! The Materials Project "task detail" pages were intended as a proof-of-concept for this component. Changing it to a general TaskDocument component was considered beneficial since it would allow re-use of the component in e.g. an atomate2 UI or in other contexts. |
Oh cool! I wasn't even aware these exist. For reference: https://materialsproject.org/materials/mp-1033715/tasks/mp-1033715 Perhaps the convergence graph should have the option to toggle between showing electronic and ionic steps as it can be hard to read for long trajectories. @mkhorton I'll create a tracking issue for that. |
Might even be useful on the MP website for investigating unusual relaxations like
mp-1033715
in this screen recording. Curious to know your thoughts @mkhorton.Screen.Recording.2023-03-18.at.19.04.03.mp4
I originally built this to inspect relaxations from ML IAPs like M3GNet and CHGNet (related PR CederGroupHub/chgnet#14) but then thought this would make a good example app too.