[BUG] Show disordered sites without gaps #441
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show disordered sites without gaps
Currently there are rendering artifacts that results in some weird looking sites when there is partial occupancy.
This is due to some weirdness with how the
phiStart
andphiEnds
are being parse after the python part of the code.If I try to draw a 0.2/0.2/0.2 alloy site then it becomes more obvious that something is wrong.
The data at the python level is here:
Here the three colors should each be 1/5 of the circle and fit together, but it looks like the
phi
size of these are doubling each time we go to a new species.Since the starting phi positions of these are still correct we can mostly fix the plots by nesting the spheres inside each other as I do in this PR. but it would be nice to figure out what exactly is going wrong.