Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a suggestion to change predict_structure function name of m3gNet to predict_energy #55

Open
usccolumbia opened this issue Jan 26, 2023 · 1 comment

Comments

@usccolumbia
Copy link

from m3gnet.models import M3GNet
m3gnet_e_form = M3GNet.load()
m3gnet_e_form.predict_structure(struc)

In the current m3gNet, we call the predict_structure function to calculate energy, which is very confusing.
You should really name the function as predict_energy(), instead of predict_structure(), isn't it?

@shyuep
Copy link
Contributor

shyuep commented Jan 26, 2023

Thanks for the feedback. We will certainly make that change but we will do so in the new DGL version that is slated to replace this version. This TF version will be deprecated soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants