Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi select books and update book type #313

Merged
merged 8 commits into from
Sep 16, 2023

Conversation

vbh
Copy link
Contributor

@vbh vbh commented Jul 29, 2023

  • Adds multi select option in menu options
  • Select multiple books in both list view and grid view
  • Update book type for the selected books from all the tabs

This PR does not implement checking the common book type of all the selected books and show it by default in change book type model.

Grid View List View
Grid view List view

@mateusz-bak
Copy link
Owner

@vbh Just tested it. I like the idea! My points:

  • can you get rid off the "multi select" button? so the feature is enabled on long press?
  • would be nice to have other edit options as well. I think editing author, status and deleting books would fit there too.

@vbh
Copy link
Contributor Author

vbh commented Sep 16, 2023

@mateusz-bak Removed multi select button. Regarding other options, I'll try to do it in a separate PR when I get some time.

Copy link
Owner

@mateusz-bak mateusz-bak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one thing:

updateBookType in book_cubit.dart line 120 should also call getAllBooksByStatus(); for the book lists to reload.

I'll merge this PR and change. Awesome work, thanks!

@mateusz-bak mateusz-bak merged commit 898a958 into mateusz-bak:master Sep 16, 2023
0 of 2 checks passed
@mateusz-bak mateusz-bak added this to the Release 2.2.0 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants