Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression: Display the Welcome page when there are no databases #4098

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

pavish
Copy link
Member

@pavish pavish commented Dec 24, 2024

Before #4072, we had this behaviour when there are no databases:

  • Visiting '/' would display the welcome page
  • Visiting '/databases' would simply show an empty state saying there are no databases

This behaviour was odd to begin with, and was a consequence of the redirection logic.

After #4072, we no longer have redirection based on number of databases, and the welcome page is no longer shown.

This PR fixes that and displays the Welcome content when there are no databases. Note that since this content is part of the home page, the background color is retained.

Screenshots

Visting '/', the home page Visting '/databases' - 'Manage databases' page
Before #4072 Screenshot 2024-12-24 at 1 53 16 PM Screenshot 2024-12-24 at 1 53 31 PM
In #4072 Screenshot 2024-12-24 at 2 00 46 PM N/A
In this PR Screenshot 2024-12-24 at 1 58 07 PM N/A

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@pavish pavish added the pr-status: review A PR awaiting review label Dec 24, 2024
I had to resolve some conflicts in HomePage.svelte that wiped out
previous work to highlight newly-added databases. This commit adds those
changes back in — now in DatabaseList.svelte instead of HomePage.svelte.
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @pavish.

I had been intending to clean this up as part of #4057, but you beat me to it. Wonderful!

Works great!

I added some commits to resolve merge conflicts and fix a lint warning.

@seancolsen seancolsen enabled auto-merge January 3, 2025 02:09
@seancolsen seancolsen added this pull request to the merge queue Jan 3, 2025
Merged via the queue into develop with commit df74db3 Jan 3, 2025
71 checks passed
@seancolsen seancolsen deleted the welcome_page branch January 3, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants