Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test files after total row fixes in core #102

Open
wants to merge 1 commit into
base: 5.x-dev
Choose a base branch
from

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 20, 2025

Description:

With matomo-org/matomo#22895 total row calculation in core was improved. It now only includes metrics that are actually present in the report. Also certain metrics are now calculated correctly.

Review

@sgiehl sgiehl requested a review from a team January 20, 2025 20:11
Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is failing currently, but when I check out dev-17662 for Matomo core, the test cases are passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants