Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Log clearer errors when picklekey goes missing #12971

Closed
wants to merge 3 commits into from
Closed

Log clearer errors when picklekey goes missing #12971

wants to merge 3 commits into from

Commits on Sep 11, 2024

  1. tokens.ts: improve documentation 

    Improve variable naming and documentation on the methods in `tokens.ts`.
    @richvdh
    richvdh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    642058d View commit details
    Browse the repository at this point in the history

  2. rename restoreFromLocalStorage 

    Since the session data isn't actually stored in localstorage, this feels like a
misleading name.
    @richvdh
    richvdh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b13655b View commit details
    Browse the repository at this point in the history

  3. Lifecycle: bail out if picklekey is missing 

    Currently, if we have an accesstoken which is encrypted with a picklekey, but
the picklekey has gone missing, we carry on with no access token at all. This
is sure to blow up in some way or other later on, but in a rather cryptic way.

Instead, let's bail out early.

(This will produce a "can't restore session" error, but we normally see one of
those anyway because we can't initialise the crypto store.)
    @richvdh
    richvdh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ab50038 View commit details
    Browse the repository at this point in the history