Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for authenticated SMTP with a custom port #38

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix support for authenticated SMTP with a custom port #38

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b52e6e
Fix email support
awesome-michael Dec 6, 2021
82d172a
Create 38.misc
awesome-michael Dec 6, 2021
710dca0
Use net/SplitHostPort
awesome-michael Dec 17, 2021
bcf30ae
Reword changelog
awesome-michael Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/38.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix email support to support mail setups with different ports than 25.
awesome-michael marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 3 additions & 1 deletion submit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"log"
"mime"
"mime/multipart"
"net"
"net/http"
"net/smtp"
"os"
Expand Down Expand Up @@ -664,7 +665,8 @@ func (s *submitServer) sendEmail(p parsedPayload, reportDir string) error {

var auth smtp.Auth = nil
if s.cfg.SMTPPassword != "" || s.cfg.SMTPUsername != "" {
auth = smtp.PlainAuth("", s.cfg.SMTPUsername, s.cfg.SMTPPassword, s.cfg.SMTPServer)
host, _, _ := net.SplitHostPort(s.cfg.SMTPServer)
auth = smtp.PlainAuth("", s.cfg.SMTPUsername, s.cfg.SMTPPassword, host)
}
err := e.Send(s.cfg.SMTPServer, auth)
if err != nil {
Expand Down