Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add link to archive in the submitted issue #81

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Aug 1, 2023

This adds a link to the full archive of the rageshake logs, avoiding a few manual steps to download them. For what it's worth, the server will happily respond with the full archive even in the presence of a trailing slash in the listingURL (it might be an HTTP thing).

@bnjbvr bnjbvr requested a review from richvdh as a code owner August 1, 2023 14:43
@bnjbvr
Copy link
Member Author

bnjbvr commented Aug 4, 2023

@richvdh Gentle review ping :)

@richvdh richvdh changed the title feat: add link to archive in the submitted issue add link to archive in the submitted issue Aug 8, 2023
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I was away.

LGTM otherwise, thanks!

By the way, note we don't use conventional commits in this project.

changelog.d/81.feature Outdated Show resolved Hide resolved
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@richvdh richvdh merged commit 7ea1cb0 into master Aug 8, 2023
6 checks passed
@bnjbvr bnjbvr deleted the add-link-to-archive branch August 11, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants