Improve console feedback and add sound effects to --watch mode #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the following improvements to `mt --watch`: - The console is cleared just before running tests. This makes it easier to notice when a change has been detected and tests are starting. It also makes the output from the latest test run easy to distinguish, since it is no longer mixed in with previous runs. - On macOS, two different sounds are played at the conclusion of the test run, depending on whether the tests passed or failed. This makes it easy to tell the result of a test while doing TDD without having to even glance at the console. The clear screen and sound playback functions have been extracted into a `Console` class. They are only enabled when running `mt` with a TTY. Sound playback is only enabled on macOS.
mattbrictson
added
✨ Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the following improvements to
mt --watch:The clear screen and sound playback functions have been extracted into a
Consoleclass. They are only enabled when runningmtwith a TTY. Sound playback is only enabled on macOS.