Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use the toolchain enum instead of a flag #21

Merged
merged 2 commits into from
Aug 20, 2024
Merged

feat: use the toolchain enum instead of a flag #21

merged 2 commits into from
Aug 20, 2024

Conversation

hedgar2017
Copy link
Contributor

@hedgar2017 hedgar2017 commented Aug 17, 2024 •
edited
Loading

What ❔

  1. Uses the --toolchain parameter rather than a simple switch flag.
  2. Rename target to lowercase to match LLVM target triples used to initialize the target machine.

Why ❔

  1. Soon we'll have 3 toolchains, so a flag is not enough.
  2. Targets shall be named just like in LLVM.

Checklist

  • PR title corresponds to the body of PR.
  • Documentation comments have been added / updated.

@hedgar2017 hedgar2017 merged commit 5563daf into main Aug 20, 2024
1 check passed
@hedgar2017 hedgar2017 deleted the az-cpr-1794-split-target-parameter-of-compiler-tester branch August 20, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonbaliasnikov antonbaliasnikov antonbaliasnikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedgar2017 @antonbaliasnikov