feat(resources): improve usage of title and name attributes

mattermack · Sep 14, 2017 · 915a7ee · 915a7ee
1 parent 3a9a178
commit 915a7ee
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 7 deletions.
diff --git a/lib/pact_broker/api/decorators/pact_collection_decorator.rb b/lib/pact_broker/api/decorators/pact_collection_decorator.rb
@@ -29,8 +29,7 @@ def create_representable_pact pact
           represented.collect do | pact |
             {
               :href => latest_pact_url(options[:base_url], pact),
-              :name => "Latest pact between #{pact.consumer.name} and #{pact.provider.name}",
-              :title => "Pact"
+              :title => "Latest pact between #{pact.consumer.name} and #{pact.provider.name}",
             }
           end
         end

diff --git a/lib/pact_broker/api/decorators/pact_versions_decorator.rb b/lib/pact_broker/api/decorators/pact_versions_decorator.rb
@@ -11,8 +11,7 @@ class PactVersionsDecorator < BaseDecorator
         link :self do | context |
           {
             href: context[:resource_url],
-            title: "Pact versions",
-            name: "All versions of the pact between #{context[:consumer_name]} and #{context[:provider_name]}"
+            title: "All versions of the pact between #{context[:consumer_name]} and #{context[:provider_name]}"
           }
         end
 

diff --git a/lib/pact_broker/api/decorators/webhook_decorator.rb b/lib/pact_broker/api/decorators/webhook_decorator.rb
@@ -43,9 +43,7 @@ class WebhookDecorator < BaseDecorator
             title: "Test the execution of the webhook by sending a POST request to this URL",
             href: webhook_execution_url(represented, options[:base_url])
           }
-
         end
-
       end
     end
   end

diff --git a/lib/pact_broker/api/decorators/webhooks_decorator.rb b/lib/pact_broker/api/decorators/webhooks_decorator.rb
@@ -38,7 +38,6 @@ class WebhooksDecorator < BaseDecorator
             templated: true
           }]
         end
-
       end
     end
   end