Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-454] Fix Invalid message while creating subscription for a project with no access to create webhook #512

Merged
merged 5 commits into from
Nov 22, 2024
Merged

[MM-454] Fix Invalid message while creating subscription for a project with no access to create webhook #512

merged 5 commits into from
Nov 22, 2024

Conversation

raghavaggarwal2308
Copy link
Contributor

Summary

  • Users we not able to create subscription for a project in which they did not had access to create webhook.
  • Updated the code to post a message in the above case instead preventing the user from creating subscription.

Screenshots:

image

What to test?

  • Getting proper messages while creating subscription for a project with no access to create webhook.

How to test?

  1. Connect your Gitlab account
  2. Try to create a subscrition for a project with no access to create subscription

Ticket Link

Fixes #454
Fixes #509

@raghavaggarwal2308 raghavaggarwal2308 self-assigned this Jul 17, 2024
ayusht2810
ayusht2810 reviewed Jul 18, 2024
View reviewed changes
server/command.go Outdated Show resolved Hide resolved
server/command.go Show resolved Hide resolved
wiggin77
wiggin77 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jul 31, 2024
arush-vashishtha
arush-vashishtha approved these changes Nov 21, 2024
View reviewed changes
Copy link

@arush-vashishtha arush-vashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested and verified the message while creating subscription for a project in which the user has the role of a developer. LGTM.

@raghavaggarwal2308 raghavaggarwal2308 added this to the v1.10.0 milestone Nov 22, 2024
@raghavaggarwal2308 raghavaggarwal2308 merged commit d70c438 into master Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arush-vashishtha arush-vashishtha arush-vashishtha approved these changes

@ayusht2810 ayusht2810 ayusht2810 approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

@mickmister mickmister Awaiting requested review from mickmister

@spirosoik spirosoik Awaiting requested review from spirosoik spirosoik is a code owner

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees

@raghavaggarwal2308 raghavaggarwal2308

Labels
2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester
Projects
None yet
Milestone
v1.10.0
6 participants
@raghavaggarwal2308 @wiggin77 @ayusht2810 @arush-vashishtha @hanzei @Kshitij-Katiyar