Skip to content

Commit

Permalink
Deprecate --require-target-macos-version
Browse files Browse the repository at this point in the history
This flag is redundant and does not mesh well with the MACOSX_DEPLOYMENT_TARGET environment variable.
  • Loading branch information
HexDecimal committed Jul 8, 2024
1 parent 9a554a5 commit 1561977
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
6 changes: 6 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ rules on making a good Changelog.
version to `delocate==0.11.0`.
[#215](https://github.com/matthew-brett/delocate/pull/215)

### Deprecated

- `--require-target-macos-version` has been deprecated.
`MACOSX_DEPLOYMENT_TARGET` should be used instead of this flag.
[#219](https://github.com/matthew-brett/delocate/pull/219)

### Fixed

- Existing libraries causing DelocationError were not shown due to bad string
Expand Down
6 changes: 5 additions & 1 deletion delocate/cmd/delocate_wheel.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"""Copy, relink library dependencies for wheel.
Overwrites the wheel in-place by default.
This script respects the MACOSX_DEPLOYMENT_TARGET environment variable.
Set MACOSX_DEPLOYMENT_TARGET to verify and target a specific macOS release.
"""

# vim: ft=python
Expand Down Expand Up @@ -69,7 +72,8 @@
parser.add_argument(
"--require-target-macos-version",
type=Version,
help="Verify if platform tag in wheel name is proper",
help="Verify if platform tag in wheel name is proper (deprecated)"
"\nConfigure MACOSX_DEPLOYMENT_TARGET instead of using this flag",
default=None,
)

Expand Down

0 comments on commit 1561977

Please sign in to comment.