Skip to content

Commit

Permalink
Document and test suffixes for non-package modules
Browse files Browse the repository at this point in the history
  • Loading branch information
HexDecimal committed Jun 7, 2024
1 parent 90094d1 commit a95f96c
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
6 changes: 6 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ rules on making a good Changelog.

## [Unreleased]

### Added

- `delocate-wheel` `--lib-sdir` now changes the suffix of the bundled library
directory.
[#210](https://github.com/matthew-brett/delocate/pull/210)

### Changed

- Improved error message for when a MacOS target version is not met.
Expand Down
4 changes: 3 additions & 1 deletion delocate/cmd/delocate_wheel.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@
action="store",
type=str,
default=".dylibs",
help="Subdirectory in packages to store copied libraries",
help="Subdirectory in packages to store copied libraries"
"\nFor non-package wheels this will be used as a suffix for the library "
"directory",
)
parser.add_argument(
"-w",
Expand Down
6 changes: 4 additions & 2 deletions delocate/tests/test_wheelies.py
Original file line number Diff line number Diff line change
Expand Up @@ -455,12 +455,14 @@ def test_fix_toplevel() -> None:

assert (
delocate_wheel(
TOPLEVEL_WHEEL, "out-1.0-cp39-cp39-macosx_10_9_x86_64.whl"
TOPLEVEL_WHEEL,
"out-1.0-cp39-cp39-macosx_10_9_x86_64.whl",
lib_sdir=".suffix_test",
)
== stray_libs
)
with InWheel("out-1.0-cp39-cp39-macosx_10_9_x86_64.whl") as wheel_path:
assert "fakepkg_toplevel.dylibs" in os.listdir(wheel_path)
assert "fakepkg_toplevel.suffix_test" in os.listdir(wheel_path)


@pytest.mark.xfail(sys.platform != "darwin", reason="otool")
Expand Down

0 comments on commit a95f96c

Please sign in to comment.