Update CI workflows, update assert_winfo_similar #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix winfo check for setuptools>=70.1 Generator field can be "setuptools <version>" instead of "bdist_wheel <version>" since setuptools 70.1. Improve assertion check to give more info when the assertion fails. Lengthen names, add type hinting, add pathlib support, add docstrings.
Update pre-commit hooks. Move deployment to main CI workflow. Mainly to ensure that the deployed wheel is the exact wheel used for tests. Added Python 3.12 to tests. Codecov is more strict and will fail for forks outside of PR's Report if test data is reproducible and committed in CI Add coverage.xml and downloads/ to .gitignore Attempt to make test data more reproducible using SOURCE_DATE_EPOCH and PYTHONHASHSEED
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
=======================================
Coverage 96.93% 96.93%
=======================================
Files 16 16
Lines 1307 1307
=======================================
Hits 1267 1267
Misses 40 40 ☔ View full report in Codecov by Sentry. |
Improve upload speed by removing unnecessary compressing of already compressed files. Other uploads are left with default compression levels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated outdated actions in the CI workflow. All CI warnings should be resolved.
I moved the deployment job to the main CI workflow to ensure that deployed wheels have the exact same test data used for tests by the CI.
I've taken some steps to support reproducible test data. This is incomplete and will take a lot of effort to finish if it's possible in the first place.
Added Python 3.12 and 3.13 to tests.
I've removed the deprecated MacOS 11 runners before support for them ends entirely.
I was unable to add MacOS 13 because of failing tests.
While I was working on this PR, setuptools had an update which broke
assert_winfo_similar. The "Generator" field can now be "setuptools <version>" instead of "bdist_wheel <version>" since setuptools 70.1. I've decided to refactor the entire function. This can be a separate PR if necessary, but all future tests are going to fail withAssertionError: assert 'bdist_wheel (70.1.0)' == 'setuptools (70.1.0)'until this is merged.