Add test for warning when teams and user requests are both disabled

mattpolzin · Jul 7, 2024 · 4138dc9 · 4138dc9
1 parent 427e70f
commit 4138dc9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/test/Makefile b/test/Makefile
@@ -13,9 +13,7 @@ build/exec/test: $(IDR_SOURCES)
 
 export harmony
 test: build/exec/test
- cp config-command/harmony.json harmony.json.bak && \
- build/exec/test runtests $(INTERACTIVE) && \
- mv harmony.json.bak config-command/harmony.json
+ build/exec/test runtests $(INTERACTIVE)
 
 clean:
  rm -rf ./test/build
diff --git a/test/config-command/no-request-warning/expected b/test/config-command/no-request-warning/expected
@@ -0,0 +1,2 @@
+`requestUsers` and `requestTeams` are both False. This means `harmony request` commands will only ever request reviews from users that are specified with the `+<userlogin>` syntax. More commonly, you want Harmony to at least request review for either a team or a user from a team when you say `harmony request teamname`; It's suggested to either `harmony config requestUsers true` or `harmony config requestTeams true` (or both).
+
diff --git a/test/config-command/no-request-warning/run b/test/config-command/no-request-warning/run
@@ -0,0 +1,6 @@
+. ../../setup.sh
+. ../setup.sh
+
+${harmony} config requestTeams no
+
+. ../cleanup.sh