Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Kdh/issue 68 #88

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Kdh/issue 68 #88

merged 2 commits into from
Nov 4, 2020

Conversation

kdenhartog
Copy link
Contributor

Description

  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Motivation and Context

Updating contexts from the separate spec defined contexts to a newly defined v3 context.

Does this PR introduce a breaking change?

  • Yes
  • No

Which merge strategy will you use?

  • Squash
  • Rebase (REVIEW COMMITS)

@github-actions
Copy link

github-actions bot commented Nov 2, 2020

Total Coverage: 88.15%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   BbsBlsSignature2020.ts58.49%100%86.60%102, 111, 119, 124, 129, 133, 207, 208, 219, 220, 225, 318, 319, 322, 323, 341, 342, 346, 347, 361, 362, 385, 47, 48, 51, 62, 67, 71, 74, 78, 79, 80, 80, 80, 81
   BbsBlsSignatureProof2020.ts62.96%81.25%85.58%171, 172, 181, 299, 300, 305, 341, 343, 347, 353, 384, 389, 401, 402, 404, 405, 423, 424, 428, 429, 44, 69, 72, 87, 96
   deriveProof.ts83.33%100%90.91%123, 124, 33, 34, 83
   index.ts100%100%100%
   utilities.ts75%100%96.88%122, 43, 82, 83

@github-actions
Copy link

github-actions bot commented Nov 2, 2020

Total Coverage: 88.15%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   BbsBlsSignature2020.ts58.49%100%86.60%102, 111, 119, 124, 129, 133, 207, 208, 219, 220, 225, 318, 319, 322, 323, 341, 342, 346, 347, 361, 362, 385, 47, 48, 51, 62, 67, 71, 74, 78, 79, 80, 80, 80, 81
   BbsBlsSignatureProof2020.ts62.96%81.25%85.58%171, 172, 181, 299, 300, 305, 341, 343, 347, 353, 384, 389, 401, 402, 404, 405, 423, 424, 428, 429, 44, 69, 72, 87, 96
   deriveProof.ts83.33%100%90.91%123, 124, 33, 34, 83
   index.ts100%100%100%
   utilities.ts75%100%96.88%122, 43, 82, 83

tplooker
tplooker reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@tplooker tplooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some minor changes.

__tests__/__fixtures__/data/test_proof_document.json Outdated Show resolved Hide resolved
src/BbsBlsSignature2020.ts Show resolved Hide resolved
src/BbsBlsSignatureProof2020.ts Show resolved Hide resolved
@kdenhartog-mattr @kdenhartog
feat: updates signature and proof suites to use sec v3-unstable context
df8c2a3 
Updates BbsBlsSignature2020 and BbsBlsSignatureProof2020 to use
https://w3id.org/security/v3-unstable as the context and generates new fixtures to support the
updated context.

re issue #68
@github-actions
Copy link

github-actions bot commented Nov 4, 2020

Total Coverage: 88.15%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   BbsBlsSignature2020.ts58.49%100%86.60%102, 111, 119, 124, 129, 133, 207, 208, 219, 220, 225, 318, 319, 322, 323, 341, 342, 346, 347, 361, 362, 385, 47, 48, 51, 62, 67, 71, 74, 78, 79, 80, 80, 80, 81
   BbsBlsSignatureProof2020.ts62.96%81.25%85.58%171, 172, 181, 299, 300, 305, 341, 343, 347, 353, 384, 389, 401, 402, 404, 405, 423, 424, 428, 429, 44, 69, 72, 87, 96
   deriveProof.ts83.33%100%90.91%123, 124, 33, 34, 83
   index.ts100%100%100%
   utilities.ts75%100%96.88%122, 43, 82, 83

@tplooker tplooker merged commit 2673a0a into master Nov 4, 2020
@tplooker tplooker deleted the kdh/issue-68 branch November 4, 2020 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tplooker tplooker tplooker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdenhartog @tplooker @kdenhartog-mattr