This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
Fixed add new media notice, with carasmo's solution #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwatsoncodes
suggested changes
Dec 7, 2017
| @@ -22,7 +22,10 @@ function __construct() { | |||
| * Do Work | |||
| */ | |||
| public function run() { | |||
| add_action( 'admin_enqueue_scripts', array( $this, 'admin_enqueue_scripts' ) ); | |||
| global $pagenow; | |||
There was a problem hiding this comment.
Hey @m9n looking good, but a couple of code quality things:
- Ensure globals are at the top of the function.
- Use !== instead of !=
- Use 'Yoda' type expressions, so
if ( 'media-new.php' !== $pagenow )
The code sniffer should pick these up in your IDE, if they aren't let me know and we can work out why these rules are not triggering.
|
Fixed this, I think? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See for background: #5 (comment)
I applied the change to the controller assets class