Rename order parameter

[Hugo-Prossaird]

This PR fixes the order parameter. To order by a column and select a direction, we must use order, not orderBy/orderByDir.

Example:
order[1]=ASC&order[0]=timestamp

[escopecz]

Are you sure? I was trying to find a test that would prove this change but found only this which would suggest the original version:

https://github.com/mautic/mautic/blob/58a35fd04c64a790c3f939036fe211fba4877120/app/bundles/CoreBundle/Tests/Unit/Entity/CommonRepositoryTest.php#L74-L82

[Hugo-Prossaird]

Are you sure? I was trying to find a test that would prove this change but found only this which would suggest the original version:

https://github.com/mautic/mautic/blob/58a35fd04c64a790c3f939036fe211fba4877120/app/bundles/CoreBundle/Tests/Unit/Entity/CommonRepositoryTest.php#L74-L82

You can see the issue here:
https://github.com/mautic/mautic/blob/58a35fd04c64a790c3f939036fe211fba4877120/app/bundles/LeadBundle/Controller/Api/LeadApiController.php#L404

I believe that this route doesn’t use the common repository class you mentioned in the test. I believe it’s a specific route that uses its own method with custom logic.

[escopecz]

You are right 👍

[RCheesley]

The build failure is due to us having DDOS protection on one of our servers, so this is good to go.

[RCheesley]

@all-contributors please add @Hugo-Prossaird for docs

[allcontributors]

@RCheesley

I've put up a pull request to add @Hugo-Prossaird! 🎉