Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DesignTime: fix dependencies loader #239

Merged
merged 1 commit into from
Sep 28, 2024
Merged

DesignTime: fix dependencies loader #239

merged 1 commit into from
Sep 28, 2024

Conversation

max-ieremenko
Copy link
Owner

Sometimes ServiceModelGrpcGenerator fails with the AssemblyLoad exception. It can be reproduced with two or more projects referenced ServiceModel.Grpc.DesignTime.

dotnet publish my-solution.sln
my-solution.sln

   project1.csproj
     reference ServiceModel.Grpc.DesignTime
     [ImportGrpcService]

   project2.csproj
     reference ServiceModel.Grpc.DesignTime
     [ExportGrpcService]

The Roslyn instantiates one instance of ServiceModelGrpcGenerator for all projects and runs code-generation simultaneously.

@max-ieremenko max-ieremenko changed the title DesignTime: fix dependecies loader DesignTime: fix dependencies loader Sep 28, 2024
@max-ieremenko max-ieremenko merged commit 4b9cac8 into release/1.9.1 Sep 28, 2024
4 checks passed
@max-ieremenko max-ieremenko deleted the bug-fix/design-time-dependencies branch September 28, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@max-ieremenko