Update to Swift 5 #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…justing the API to a more modern naming convention and putting the data structure definitions into the classes scope. Tested on iPhone 11.
|
wow thanks ! I'll have a look this week-end ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I took the time to update the PieChart to Swift 5, including modernizing the delegate method naming, putting data structure definitions into the class and make the delegate methods optional in Swift.
Dropped the objC-Bridging.
So #4 should be solved /obsolete now.
It handles #3 by avoiding the division by zero in case total is zero.
Tested on an iPhone 11, worked smooth.
Feel free to integrate.