New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Early return when empty file string #549

Merged

barryvdh merged 1 commit into maximebf:master from erikn69:erikn69-patch-1

Sep 19, 2023

Contributor

erikn69 commented Aug 18, 2023 •

edited

Loading

When is empty $file, it returns an invalid url

->getXdebugLink('');
//returns ['url' => 'vscode://file/:1', 'ajax' => false];
->getXdebugLink(null);
//throws exception string required null given on php 8.2


          Early return when no file string

ec299d9

erikn69 changed the title ~~Early return when no file string~~ [bug] Early return when empty file string

angeljqv approved these changes

View reviewed changes

barryvdh merged commit 1b14192 into maximebf:master

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet