Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cross-origin iframe and no parent debugbar #651

Merged
merged 2 commits into from
May 13, 2024
Merged

fix cross-origin iframe and no parent debugbar #651

merged 2 commits into from
May 13, 2024

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Apr 12, 2024

Closes #650

Failed to read a named property 'phpdebugbar' from 'Window': 
Blocked a frame with origin "https://[subdomain].ngrok-free.app" from accessing a cross-origin frame.
    at child.addDataSet (https://[subdomain].ngrok-free.app/_debugbar/assets/javascript?v=1712740545:949:28)
    at https://[subdomain].ngrok-free.app/admin/dashboard?shop=[subdomain].myshopify.com&host=[...]:633:13

@erikn69 erikn69 mentioned this pull request Apr 12, 2024
Closed
@barryvdh barryvdh merged commit 7705be9 into maximebf:master May 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barryvdh barryvdh barryvdh left review comments

@jose123v jose123v jose123v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debugbar not showing in embed iframe
3 participants
@erikn69 @barryvdh @jose123v