Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging Feature #660

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

devzkhalil
Copy link

@devzkhalil devzkhalil commented Jul 9, 2024

I'm a die-hard fan of the PHP Debugbar package!

The reason for this PR!

2024-07-09_17-47

In the above image, you can see that I have a menu in the same place as the Debugbar area. Whenever I try to click on the menu, I face issues with the click! I know many people face this problem and may face it in the future!

Therefore, I have tried to implement a feature here that allows the Debugbar to be dragged!

04bbbcd8af3f43758f16dffa37277080.mp4

@devzkhalil
Copy link
Author

Great changes @erikn69

@devzkhalil
Copy link
Author

@parallels999 & @erikn69
Thank you very much. I really appreciate your help.

fix: default display css
@angeljqv
Copy link
Contributor

@barryvdh hi, it happens, look:
image

@devzkhalil
Copy link
Author

@angeljqv
Those are your app contents behind the Laravel Debugbar icon, am i right brother?

@devzkhalil
Copy link
Author

Thank you @angeljqv for sharing your scenario.
It may help others facing similar situations.

@devzkhalil
Copy link
Author

@maximebf Please review it...

@barryvdh
Copy link
Collaborator

barryvdh commented Sep 6, 2024

I don't really have this issue myself but I can see it being useful. Will try it out.

@barryvdh
Copy link
Collaborator

barryvdh commented Sep 6, 2024

So tried it, a few things come to mind:

  • the left border for the icon is missing
  • would it make sense to 'snap' to the right? If I drag it to the right corner, I would expect it to stick, even if I make it larger. It does work when making it smaller, but not larger. Not sure what the cleanest is, but I guess if we could 'flip' the offset from left to right or something?

@barryvdh
Copy link
Collaborator

barryvdh commented Sep 9, 2024

What do you think about snapping to the right? And maybe the middle?

@barryvdh
Copy link
Collaborator

barryvdh commented Sep 9, 2024

And I'm getting some misfires for extending, because it probably thinks it's dragging.

@devzkhalil
Copy link
Author

What do you think about snapping to the right? And maybe the middle?

I don't think anyone will need to drag it after opening the Debugbar content area/larger.
Still, I’m trying to show you something! I can show you something very quickly!

@devzkhalil
Copy link
Author

And I'm getting some misfires for extending, because it probably thinks it's dragging.

ups!
I will check and fix.......

@devzkhalil
Copy link
Author

So tried it, a few things come to mind:

  • the left border for the icon is missing
  • would it make sense to 'snap' to the right? If I drag it to the right corner, I would expect it to stick, even if I make it larger. It does work when making it smaller, but not larger. Not sure what the cleanest is, but I guess if we could 'flip' the offset from left to right or something?

Something like this for larger?

activity.mp4

@barryvdh
Copy link
Collaborator

Eh no sorry, thats not really what I meant. I just meant that if I drag the button to the right corner and then make the screen larger, I would probably expect the button to stick to the corner, instead of being half way.
With sticky/snapping I would mean that if you get within a few pixels of the corner, it woud 'snap' into place in the corner.

@devzkhalil
Copy link
Author

devzkhalil commented Sep 20, 2024

Eh no sorry, thats not really what I meant. I just meant that if I drag the button to the right corner and then make the screen larger, I would probably expect the button to stick to the corner, instead of being half way. With sticky/snapping I would mean that if you get within a few pixels of the corner, it woud 'snap' into place in the corner.

Yahoo! I understand! I'm on it now. Thank you brother!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants