Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide empty collectors until used #672

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

barryvdh
Copy link
Collaborator

@barryvdh barryvdh commented Sep 8, 2024

This will hide empty collectors, until the collector is actually filled using any data.
This can be useful for less-used collectors without filling up te screen.

Note:

  • It is not hidden when empty, to keep a more consistent flow when using ajax etc.
  • it's not using the badge because not every collector uses a badge

Not sure if it's worth creating a config option for.

@barryvdh
Copy link
Collaborator Author

barryvdh commented Sep 9, 2024

Or should we have a threshold for the collectors, so we can make it configurable?

@barryvdh
Copy link
Collaborator Author

Added a config flag

@barryvdh barryvdh merged commit 63bae27 into master Sep 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant