-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/its all about fonts #769
Merged
maximegmd
merged 21 commits into
maximegmd:master
from
Nats-ji:feature/its_all_about_fonts
Jun 20, 2023
Merged
Feature/its all about fonts #769
maximegmd
merged 21 commits into
maximegmd:master
from
Nats-ji:feature/its_all_about_fonts
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nats-ji
force-pushed
the
feature/its_all_about_fonts
branch
from
December 14, 2022 05:32
e805c33
to
72c4681
Compare
align font during merge
add option for custom monospace font move buildfont function to its own class
emoji icons for setting items
Nats-ji
force-pushed
the
feature/its_all_about_fonts
branch
from
December 14, 2022 06:13
72c4681
to
cffd7f3
Compare
Nats-ji
force-pushed
the
feature/its_all_about_fonts
branch
from
May 23, 2023 23:42
a902fc8
to
0d8d675
Compare
Nats-ji
force-pushed
the
feature/its_all_about_fonts
branch
from
May 26, 2023 20:56
0d8d675
to
aec45af
Compare
rename some variables
- use a font class to store font infos
Do you consider this complete? |
yes |
maximegmd
requested changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the log level, looks great !
maximegmd
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImGui.GetMonoFont()
,ImGui.PushFont()
Alternative monospace font for console #768Instead, load every glyph in the supplied font.Font preview(maybe later)Dynamic glyph ranges todo list:
AddTextGlyphs()
to luaio.open
,io.lines
) to glyph ranges builderUse monospace font from lua:
Display multilingual string:
New settings panel: