Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/its all about fonts #769

Merged
merged 21 commits into from
Jun 20, 2023

Conversation

Nats-ji
Copy link
Contributor

@Nats-ji Nats-ji commented Dec 9, 2022

  • Icons for overlay windows and settings widget
  • Vertical align the icon font
  • Emoji font 🤣 because why not (Windows 10 and above)
  • Monospace font for the console
  • Expose monospace font to mods ImGui.GetMonoFont(), ImGui.PushFont() Alternative monospace font for console #768
  • Option for custom monospace font
  • Reload font during runtime
  • GUI for changing font settings Font widget #488
  • Enumerate system font
  • Remove the glyph range option. Instead, load every glyph in the supplied font.
  • Merge the default NotoSans fonts for better multilingual support.
  • Logs
  • Font preview (maybe later)
  • Dynamic glyph range, instead of loading all glyphs

Dynamic glyph ranges todo list:

  • console logs
  • console inputtext
  • lua binding inputtext wrapper
  • expose AddTextGlyphs() to lua
  • pre-cache ".lua", ".txt", ".json", ".yml", ".yaml", ".toml", ".ini" files in mod folders
  • pre-cache all path strings in the mod folders
  • dynamically load icon glyphs from mods
  • add files opened by mods (io.open, io.lines) to glyph ranges builder

Use monospace font from lua:

ImGui.PushFont(ImGui.GetMonoFont())
ImGui.Text("This is how the monospaced font looks like")
ImGui.PopFont()

Display multilingual string:
image

New settings panel:
image

@Nats-ji Nats-ji force-pushed the feature/its_all_about_fonts branch from e805c33 to 72c4681 Compare December 14, 2022 05:32
@Nats-ji Nats-ji force-pushed the feature/its_all_about_fonts branch from 72c4681 to cffd7f3 Compare December 14, 2022 06:13
@Nats-ji Nats-ji marked this pull request as ready for review May 21, 2023 22:08
@Nats-ji Nats-ji force-pushed the feature/its_all_about_fonts branch from a902fc8 to 0d8d675 Compare May 23, 2023 23:42
@Nats-ji Nats-ji force-pushed the feature/its_all_about_fonts branch from 0d8d675 to aec45af Compare May 26, 2023 20:56
@maximegmd
Copy link
Owner

Do you consider this complete?

@Nats-ji
Copy link
Contributor Author

Nats-ji commented Jun 20, 2023

Do you consider this complete?

yes

Copy link
Owner

@maximegmd maximegmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the log level, looks great !

src/Fonts.cpp Outdated Show resolved Hide resolved
@Nats-ji Nats-ji requested a review from maximegmd June 20, 2023 17:23
@Nats-ji Nats-ji mentioned this pull request Jun 20, 2023
7 tasks
@maximegmd maximegmd merged commit d959648 into maximegmd:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants