Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use updated CGameEngine-field for ClipToCenter() #854

Closed
wants to merge 1 commit into from

Conversation

Lukas0610
Copy link
Contributor

Requires wopss/RED4ext.SDK#87 to be merged

@maximegmd
Copy link
Owner

I already fixed this in my fork of red4ext, your change to the engine class is incorrect so we should just wait for them to do a proper fix and just use my similar hack in the meantime.

@maximegmd maximegmd closed this Sep 25, 2023
@Lukas0610
Copy link
Contributor Author

You know more about the game than I do, so have to trust you on this one ^^, but it seemed correct that way as the address for UnkD0 and the window-handle were the same as when the game itself called ClipToCenter(), so I assumed it was the right one.

@maximegmd
Copy link
Owner

Yeah it is indeed at D0 but the rest of the class is probably incorrect, we need to fix the entire class

@Lukas0610
Copy link
Contributor Author

Yeah, I only patched the part for the window-data, psiberx pushed a full fix for the class just a few minutes after https://github.com/WopsS/RED4ext.SDK/pull/88/files, but he made the same changes to UnkC0 as I did, so this patch to CET should still be working as intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants