⬆️ bump open-api-framework to 0.8.0 #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annashamray
force-pushed
the
deps/oaf-0.8.0
branch
from
034a2bd to
25e61a1
Compare
annashamray
force-pushed
the
deps/oaf-0.8.0
branch
from
25e61a1 to
daa3ad4
Compare
annashamray
added
the
backport
stevenbal
reviewed
Aug 23, 2024
There was a problem hiding this comment.
@annashamray will you also add the warning about HSTS_SECONDS to the changelog? maykinmedia/open-api-framework#63 (comment)
Comment on lines
+33
to
+34
| - OBJECTS_OBJECTTYPES_CONFIG_ENABLE=false | ||
| # - OBJECTTYPES_API_ROOT=https://objecttypes.example.com/api/v2/ |
There was a problem hiding this comment.
Is it intentional to disable this?
There was a problem hiding this comment.
Yes it's a temporary fix for quick-start action
OBJECTTYPES_API_ROOT setting was incorrect (it's fixed in this PR), but quick-start doesn't use the current build, but only the published one.
So to make it work for now OBJECTTYPES_API_ROOT should be empty
|
@stevenbal I planed to add the warning when preparing the release. Do you want me to add it now? |
|
@annashamray no that's fine, was just to double check so we don't forget about it 👍 |
stevenbal
approved these changes
Aug 23, 2024
annashamray
removed
the
backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the PR is merged it would be added to patch release