Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZGW Consumers must be updated in all projects #66

Closed
6 tasks done
joeribekker opened this issue Sep 3, 2024 · 5 comments · Fixed by open-zaak/open-zaak#1800, maykinmedia/commonground-api-common#38, maykinmedia/open-klant#278, maykinmedia/objecttypes-api#134 or maykinmedia/objects-api#478
Closed
6 tasks done

ZGW Consumers must be updated in all projects #66

joeribekker opened this issue Sep 3, 2024 · 5 comments · Fixed by open-zaak/open-zaak#1800, maykinmedia/commonground-api-common#38, maykinmedia/open-klant#278, maykinmedia/objecttypes-api#134 or maykinmedia/objects-api#478
Assignees
@SonnyBA @stevenbal @annashamray
Labels
enhancement New feature or request owner: den haag

Comments

@joeribekker
Copy link
Member

joeribekker commented Sep 3, 2024 •
edited by SonnyBA
Loading

Thema / Theme

API

Omschrijving / Description

There are breaking changes but we need to bite the bullet or risk getting behind too much. My suggestion is to start with the simplest component to update and see the backlash from it. We can then report the backlash in the refinement.

Toegevoegde waarde / Added value

No response

Aanvullende opmerkingen / Additional context

No response
@joeribekker joeribekker added enhancement New feature or request owner: maykin labels Sep 3, 2024
@joeribekker joeribekker moved this from Triage to Todo in Data en API fundament Sep 3, 2024
@stevenbal stevenbal mentioned this issue Oct 3, 2024
Closed
@SonnyBA SonnyBA mentioned this issue Oct 22, 2024
Merged
@stevenbal stevenbal mentioned this issue Oct 25, 2024
Merged
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Oct 31, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes to work with commongrou…
1e26536 
…nd-api-common upgrade
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Oct 31, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes for updated commongroun…
e9f1f2e 
…d-api-common
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 1, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes for updated commongroun…
46381d4 
…d-api-common
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 1, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes for updated commongroun…
13fc36e 
…d-api-common
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 1, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes for updated commongroun…
1c6ba83 
…d-api-common
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 1, 2024
@stevenbal
📌 [maykinmedia/open-api-framework#66] Pin commonground-api-common
18834a1
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 1, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes to work with commongrou…
3503da6 
…nd-api-common upgrade
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 1, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes for updated commongroun…
c79c265 
…d-api-common
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 1, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes for updated commongroun…
aceeaed 
…d-api-common
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 1, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes to work with commongrou…
b215790 
…nd-api-common upgrade
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 1, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes for updated commongroun…
195858f 
…d-api-common
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 7, 2024
@stevenbal
📌 [maykinmedia/open-api-framework#66] Pin commonground-api-common
0cdeb84
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 7, 2024
@stevenbal
📌 [maykinmedia/open-api-framework#66] Pin cmis-adapter to branch
33950da
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 7, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes to work with commongrou…
ed3eb0d 
…nd-api-common upgrade
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 7, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes for updated commongroun…
51c60e2 
…d-api-common
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 7, 2024
@stevenbal
✅ [maykinmedia/open-api-framework#66] Fix failing tests due to zgw-co…
4e0f28b 
…nsumers update
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 7, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes to work with commongrou…
74038ae 
…nd-api-common upgrade
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 7, 2024
@stevenbal
👽 [maykinmedia/open-api-framework#66] Changes for updated commongroun…
77bca96 
…d-api-common
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 7, 2024
@stevenbal
✅ [maykinmedia/open-api-framework#66] Fix failing tests due to zgw-co…
e898b31 
…nsumers update
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 28, 2024
@stevenbal
📌 [maykinmedia/open-api-framework#66] Pin commonground-api-common to …
2c0c948 
…branch
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 28, 2024
@stevenbal
👌 [maykinmedia/open-api-framework#66] PR feedback
0e8ef5b 
* reuse ServiceConfigAdapter for utils.get_auth
* fix FkOrServiceUrlFactoryMixin not generating services because of missing slug and remove unnecessary ServiceFactory.creates
* add changelog warning to check Selectielijstconfiguratie service
* create Selectielijst service in migration if it does not exist yet
* reuse _test_nrc_config from commonground-api-common
* reuse client utils from commonground-api-common
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 28, 2024
@stevenbal
📌 [maykinmedia/open-api-framework#66] Pin commonground-api-common to …
89bc07a 
…branch
@stevenbal
Copy link
Contributor

I think open-api-framework also should be version bumped and pinned to the earlier mentioned commground-api-common version?

I agree

We can start doing it, but I don't think it's critical for the PRs linked to this issue

let's indeed not make it blocking for these PRs

stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 29, 2024
@stevenbal
📝 [maykinmedia/open-api-framework#66] Update lib versions in changelog
ace5086
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 29, 2024
@stevenbal
👌 [maykinmedia/open-api-framework#66] Process PR feedback
f50a5ce
annashamray added a commit to maykinmedia/objecttypes-api that referenced this issue Nov 29, 2024
@annashamray
⬆️ [maykinmedia/open-api-framework#66] bump commonground-api-common t…
7f47733 
…o 2.1.0
@github-project-automation github-project-automation bot moved this from In Progress to Done in Data en API fundament Nov 29, 2024
@annashamray annashamray reopened this Nov 29, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Data en API fundament Nov 29, 2024
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Nov 29, 2024
@stevenbal
Merge pull request #1800 from open-zaak/issue/66-update-zgw-consumers
992133f 
⬆️ [maykinmedia/open-api-framework#66] Update zgw-consumers to 0.35.1
@github-project-automation github-project-automation bot moved this from In Progress to Done in Data en API fundament Nov 29, 2024
@stevenbal stevenbal reopened this Nov 29, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Data en API fundament Nov 29, 2024
annashamray added a commit to maykinmedia/referentielijsten that referenced this issue Nov 29, 2024
@annashamray
⬆️ [maykinmedia/open-api-framework#66] bump commongground-api-common …
634b940 
…to 2.1.0
@github-project-automation github-project-automation bot moved this from In Progress to Done in Data en API fundament Nov 29, 2024
@annashamray annashamray reopened this Nov 29, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Data en API fundament Nov 29, 2024
annashamray added a commit to maykinmedia/objects-api that referenced this issue Nov 29, 2024
@annashamray
⬆️ [maykinmedia/open-api-framework#66] bump commonground-api-common t…
14137d1 
…o 2.1.0
annashamray added a commit to maykinmedia/objects-api that referenced this issue Nov 29, 2024
@annashamray
👌 [maykinmedia/open-api-framework#66] change mocks for 'register_kana…
e0ff502 
…len' tests
@annashamray annashamray reopened this Nov 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Data en API fundament Nov 29, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Data en API fundament Nov 29, 2024
@SonnyBA SonnyBA closed this as completed Nov 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Data en API fundament Nov 29, 2024
@SonnyBA SonnyBA mentioned this issue Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SonnyBA SonnyBA

@stevenbal stevenbal

@annashamray annashamray

Labels
enhancement New feature or request owner: den haag
Projects
Data en API fundament
Status: Done
Milestone
No milestone
5 participants
@joeribekker @alextreme @SonnyBA @stevenbal @annashamray