Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗃️ [#61] created Partij, Persoon, ContactPersoon and Organisatie models #73

Closed
wants to merge 1 commit into from

Conversation

bart-maykin
Copy link
Contributor

Fixes #61

Added the models:

  • Partij
  • Persoon
  • ContactPersoon
  • Organisatie

Added django choice options acording to the Enumeratie

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #73 (4a8c2d2) into master (d481f5f) will increase coverage by 0.10%.
Report is 8 commits behind head on master.
The diff coverage is 98.30%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   96.15%   96.25%   +0.10%     
==========================================
  Files          99      104       +5     
  Lines        3508     3684     +176     
==========================================
+ Hits         3373     3546     +173     
- Misses        135      138       +3     
Files Coverage Δ
...rc/openklant/components/klanten/api/serializers.py 85.71% <ø> (ø)
...enklant/components/klanten/api/tests/test_klant.py 100.00% <100.00%> (ø)
...ents/klanten/migrations/0005_auto_20230905_1215.py 100.00% <100.00%> (ø)
src/openklant/components/klanten/models/klanten.py 92.37% <100.00%> (+0.94%) ⬆️
src/openklant/components/klantinteracties/apps.py 100.00% <100.00%> (ø)
...openklant/components/klantinteracties/constants.py 100.00% <100.00%> (ø)
...onents/klantinteracties/migrations/0001_initial.py 100.00% <100.00%> (ø)
src/openklant/conf/base.py 94.84% <ø> (ø)
...rc/openklant/components/klantinteracties/models.py 95.23% <95.23%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bart-maykin bart-maykin force-pushed the feature/61-partij-models branch 4 times, most recently from 6989ecb to b512559 Compare October 12, 2023 09:04
Copy link

@SilviaAmAm SilviaAmAm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the Partij model for now, will continue tomorrow 🙂

src/openklant/components/klantinteracties/models.py Outdated Show resolved Hide resolved
src/openklant/components/klantinteracties/models.py Outdated Show resolved Hide resolved
src/openklant/components/klantinteracties/models.py Outdated Show resolved Hide resolved
src/openklant/components/klantinteracties/models.py Outdated Show resolved Hide resolved
src/openklant/components/klantinteracties/models.py Outdated Show resolved Hide resolved
src/openklant/components/klantinteracties/models.py Outdated Show resolved Hide resolved
src/openklant/components/klantinteracties/models.py Outdated Show resolved Hide resolved
src/openklant/components/klantinteracties/models.py Outdated Show resolved Hide resolved
src/openklant/components/klantinteracties/models.py Outdated Show resolved Hide resolved
@bart-maykin bart-maykin force-pushed the feature/61-partij-models branch 2 times, most recently from 0ef7106 to c4c8265 Compare October 13, 2023 10:29
)

# Correspondentieadres model fields:
correspondentieadres_nummeraanduiding_id = models.UUIDField(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wijzig naar CharField(255) met een # TODO er bij dat dit nog opgehelderd moet worden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Als koploper wil ik een Partijen kunnen registreren
4 participants