close io object when fixture writing has completed #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So typically, when passing a block to
File.open
, theIO
object with automatically close when the block terminates. However, we have notice when attempting to write fixtures for largish database dumps that theIO
stream is closing before the last few strings are written.I believe the cause of this is here:
https://github.com/mbleigh/seed-fu/blob/master/lib/seed-fu/writer.rb#L96-L98
Basically, the
ensure
is killing the the stream before the last chunks have been written to the file by niling it.I am not sure this solution is the best, but it solved our issue. I might take a stab at refactoring this code later.