fix: only adjust headsign to last predicted stop on subway routes #840
+82
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoops
force-pushed
the
wh-added-headsigns-subway
branch
from
f9a003a
to
01924c7
Compare
Whoops
requested review from
a team and
bfauble
and removed request for
a team
Coverage of commit
|
bfauble
reviewed
Nov 27, 2024
apps/state/lib/state/trip/added.ex
Outdated
| # A large number of unrelated tests end up calling this function without | ||
| # having set up a route, from predictions to the rate limiter, so we | ||
| # guard against that here | ||
| route_type = if route, do: route.type |
There was a problem hiding this comment.
instead of this, you could update the subway? function definition to something like....
defp subway?(%Route{type: type}), do: subway?(type)
defp subway?(type) when type in [0, 1], do: true
defp subway(_), do: false
Whoops
force-pushed
the
wh-added-headsigns-subway
branch
from
01924c7
to
6a7a886
Compare
Whoops
force-pushed
the
wh-added-headsigns-subway
branch
from
6a7a886
to
79eea68
Compare
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: 🍎 Constraint "Adjust API headsign logic for ADDED trips" to subway/light rail