Make shuttle route page use LiveView (#1033)

* chore: migration to separate out foreign keys

* fix: get seeds.exs working with schema changes

* chore: various small schema updates

* refactor: migrate shuttle page to LiveView

* test: test for shuttle route LiveView

* refactor: make use of helper functions in Arrow.Shuttles for changes

* fixup! refactor: make use of helper functions in Arrow.Shuttles for changes

* refactor: rename erroneous references to shuttle_route

* refactor: remove unneeded on_replace: :delete

* fix: update shuttle_live to assign initial shuttle for validate call, update seeds for FK duplication (#1034)


---------

Co-authored-by: Eddie Maldonado <emaldonado@mbta.com>

---------

Co-authored-by: meagharty <149533950+meagharty@users.noreply.github.com>

lib/arrow/shuttles/route.ex

@@ -11,6 +11,7 @@ defmodule Arrow.Shuttles.Route do
     field :waypoint, :string
     belongs_to :shuttle, Arrow.Shuttles.Shuttle
     belongs_to :shape, Arrow.Shuttles.Shape
+    has_many :route_stop, Arrow.Shuttles.RouteStop, foreign_key: :shuttle_route_id
 
     timestamps(type: :utc_datetime)
   end
@@ -19,7 +20,7 @@ defmodule Arrow.Shuttles.Route do
   def changeset(route, attrs) do
     route
     |> cast(attrs, [:direction_id, :direction_desc, :destination, :waypoint, :suffix, :shape_id])
-    |> foreign_key_constraint(:shape_id)
     |> validate_required([:direction_id, :direction_desc, :destination])
+    |> assoc_constraint(:shape)
   end
 end

lib/arrow/shuttles/route_stop.ex

@@ -5,18 +5,22 @@ defmodule Arrow.Shuttles.RouteStop do
 
   schema "shuttle_route_stops" do
     field :direction_id, Ecto.Enum, values: [:"0", :"1"]
-    field :stop_id, :string
     field :stop_sequence, :integer
     field :time_to_next_stop, :decimal
-    belongs_to :route, Arrow.Shuttles.Route
+    belongs_to :shuttle_route, Arrow.Shuttles.Route
+    belongs_to :stop, Arrow.Shuttles.Stop
+    belongs_to :gtfs_stop, Arrow.Gtfs.Stop, type: :string
 
     timestamps(type: :utc_datetime)
   end
 
   @doc false
   def changeset(route_stop, attrs) do
     route_stop
-    |> cast(attrs, [:direction_id, :stop_id, :stop_sequence, :time_to_next_stop])
-    |> validate_required([:direction_id, :stop_id, :stop_sequence, :time_to_next_stop])
+    |> cast(attrs, [:direction_id, :stop_id, :gtfs_stop_id, :stop_sequence, :time_to_next_stop])
+    |> validate_required([:direction_id, :stop_sequence, :time_to_next_stop])
+    |> assoc_constraint(:shuttle_route)
+    |> assoc_constraint(:stop)
+    |> assoc_constraint(:gtfs_stop)
   end
 end

lib/arrow/shuttles/shuttle.ex

@@ -7,6 +7,7 @@ defmodule Arrow.Shuttles.Shuttle do
     field :status, Ecto.Enum, values: [:draft, :active, :inactive]
     field :shuttle_name, :string
     field :disrupted_route_id, :string
+
     has_many :routes, Arrow.Shuttles.Route, preload_order: [asc: :direction_id]
 
     timestamps(type: :utc_datetime)

lib/arrow_web/controllers/shuttle_controller.ex

@@ -2,87 +2,14 @@ defmodule ArrowWeb.ShuttleController do
   use ArrowWeb, :controller
 
   alias Arrow.Shuttles
-  alias Arrow.Shuttles.Shuttle
 
   def index(conn, _params) do
     shuttles = Shuttles.list_shuttles()
     render(conn, :index, shuttles: shuttles)
   end
 
-  def new(conn, _params) do
-    changeset =
-      Shuttles.change_shuttle(%Shuttle{
-        status: :draft,
-        routes: [%Shuttles.Route{direction_id: :"0"}, %Shuttles.Route{direction_id: :"1"}]
-      })
-
-    gtfs_disruptable_routes = Shuttles.list_disruptable_routes()
-    shapes = Shuttles.list_shapes()
-
-    render(conn, :new,
-      changeset: changeset,
-      gtfs_disruptable_routes: gtfs_disruptable_routes,
-      shapes: shapes
-    )
-  end
-
-  def create(conn, %{"shuttle" => shuttle_params}) do
-    case Shuttles.create_shuttle(shuttle_params) do
-      {:ok, shuttle} ->
-        conn
-        |> put_flash(:info, "Shuttle created successfully.")
-        |> redirect(to: ~p"/shuttles/#{shuttle}")
-
-      {:error, %Ecto.Changeset{} = changeset} ->
-        gtfs_disruptable_routes = Shuttles.list_disruptable_routes()
-        shapes = Shuttles.list_shapes()
-
-        render(conn, :new,
-          changeset: changeset,
-          gtfs_disruptable_routes: gtfs_disruptable_routes,
-          shapes: shapes
-        )
-    end
-  end
-
   def show(conn, %{"id" => id}) do
     shuttle = Shuttles.get_shuttle!(id)
     render(conn, :show, shuttle: shuttle)
   end
-
-  def edit(conn, %{"id" => id}) do
-    shuttle = Shuttles.get_shuttle!(id)
-    changeset = Shuttles.change_shuttle(shuttle)
-    gtfs_disruptable_routes = Shuttles.list_disruptable_routes()
-    shapes = Shuttles.list_shapes()
-
-    render(conn, :edit,
-      shuttle: shuttle,
-      changeset: changeset,
-      gtfs_disruptable_routes: gtfs_disruptable_routes,
-      shapes: shapes
-    )
-  end
-
-  def update(conn, %{"id" => id, "shuttle" => shuttle_params}) do
-    shuttle = Shuttles.get_shuttle!(id)
-
-    case Shuttles.update_shuttle(shuttle, shuttle_params) do
-      {:ok, shuttle} ->
-        conn
-        |> put_flash(:info, "Shuttle updated successfully.")
-        |> redirect(to: ~p"/shuttles/#{shuttle}")
-
-      {:error, %Ecto.Changeset{} = changeset} ->
-        gtfs_disruptable_routes = Shuttles.list_disruptable_routes()
-        shapes = Shuttles.list_shapes()
-
-        render(conn, :edit,
-          shuttle: shuttle,
-          changeset: changeset,
-          gtfs_disruptable_routes: gtfs_disruptable_routes,
-          shapes: shapes
-        )
-    end
-  end
 end

lib/arrow_web/controllers/shuttle_html.ex

@@ -2,14 +2,4 @@ defmodule ArrowWeb.ShuttleView do
   use ArrowWeb, :html
 
   embed_templates "shuttle_html/*"
-
-  @doc """
-  Renders a shuttle form.
-  """
-  attr :changeset, Ecto.Changeset, required: true
-  attr :action, :string, required: true
-  attr :gtfs_disruptable_routes, :list, required: true
-  attr :shapes, :list, required: true
-
-  def shuttle_form(assigns)
 end