-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GTFS feed import #1013
feat: GTFS feed import #1013
Conversation
* feat: Create tables for GTFS-static archive import * Clean up comments
…ta into gtfs_* tables
Drive by commentary based on a skimming of the implementation:
|
@Whoops Re: directions.txt rows referencing nonexistent routes, Based on what I see here, it seems like at least for shuttle routes we make an exception and keep rows in directions.txt that reference nonexistent (I'm not sure why directions referencing bus route 602 doesn't get removed by this line though, they definitely should be) |
Unless I'm misreading something that doesn't protect |
…constraints; define and use Importable behaviour
…1014) * fix: increase length to 100MB for multipart uploads in Plug.Parsers * ci: upgrade Github Action upload-artifact to fix deprecation error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very non-blocking commentary: if we went all-in on CSV import, I think that would allow for the removal of a lot of code. But of course that conflicts with what we just discussed around services.
priv/repo/migrations/20240826153959_create_gtfs_tables_part1.exs
Outdated
Show resolved
Hide resolved
…nvert timestamps to other representations
…to int before casting
23c2405
to
119887a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of changes
Asana Ticket: [extra] 🏹 Implement /import-GTFS Arrow endpoint
This adds the rest of the code for GTFS import, started in #1006.
I had intended to split the remaining work into more than 1 PR, but hopefully it will be easy enough to review it commit-by-commit. Happy to break it apart if that would be preferable to the reviewer.
Test-running the import
With Arrow running locally and a GTFS archive saved locally, you can run the import with the following:
(It assumes the import job is successfully enqueued in the first request, so you'll need to adjust things a bit if you're testing import of an invalid archive)
Reviewer Checklist