Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup(DeparturesAndMap): allow text wrapping #1692

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

thecristen
Copy link
Collaborator

@thecristen thecristen commented Aug 1, 2023

Adjust the "Back to all routes" control so that it can wrap long test. While we're here, also change this element to a button. This enables keyboard navigability and is more accessible.

Summary of changes

Asana Ticket: Realtime Tracking Page | Text in navigation bar falls outside of container

image image

(normal view without wrapping, for reference):

image

General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

@thecristen thecristen requested a review from a team as a code owner August 1, 2023 19:33
Adjust the "Back to all routes" control so that it can wrap long test.
While we're here, also change this element to a button. This enables keyboard navigability and is more accessible.
@thecristen thecristen merged commit a317ea8 into master Aug 2, 2023
26 checks passed
@thecristen thecristen deleted the cbj/navbar-text branch August 2, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants