fix: use R-squared instead of Pearson correlation coefficient

Fixes #48
mcanouil · Dec 26, 2023 · fb18bed · fb18bed
1 parent c363232
commit fb18bed
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: NACHO
 Title: NanoString Quality Control Dashboard
-Version: 2.0.5
+Version: 2.0.6
 Authors@R: 
     c(person(given = "Mickaël",
              family = "Canouil",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,10 @@
+# NACHO 2.0.6
+
+## Fixes
+
+- In `R/qc_positive_control.R`,
+  - fix: use R-squared instead of Pearson correlation coefficient. ([#48](https://github.com/mcanouil/NACHO/issues/48))
+
 # NACHO 2.0.5
 
 ## Fixes

diff --git a/R/qc_positive_control.R b/R/qc_positive_control.R
@@ -10,6 +10,6 @@
 qc_positive_control <- function(counts) {
   measured <- log2(counts[["Count"]])
   known <- log2(as.numeric(sub("^[^(]*\\((.*)\\)$", "\\1", counts[["Name"]]))) # plexset value: "32"
-  correlation <- stats::cor.test(known, measured)$estimate
+  correlation <- summary(stats::lm(measured ~ known))$r.squared
   unname(round(correlation, 5))
 }