bootutil/crypto: Fix local variable name typo for PSA Crypto key parse #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a local variable name typo in parse public key function for the PSA Crypto abstraction, and at the same time put the memcmp under ifdefs. Signed-off-by: Antonio de Angelis <Antonio.deAngelis@arm.com> Change-Id: Icadca37e4207ad703a853ea720a053aa2ba76411
davidvincze
approved these changes
May 3, 2023
|
Thank you for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1666 . A variable name has been changed during code review, but not in all the code branches, and was not caught by automated tests, which are not merged yet, so this was caught only when running the tests locally. This kind of issues can be covered by automation only when the simulator changes will be merged in with #1668 .