Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim: Increase test coverage for ram-load #1701

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Conversation

Roolli
Copy link

@Roolli Roolli commented May 5, 2023

This PR adds new test cases to the simulator to test the ram-load feature of MCUboot. New test variations have also been added for the simulator CI.

@de-nordic de-nordic requested a review from d3zd3z May 9, 2023 10:26
@de-nordic de-nordic added the area: sim Affects the simulator label May 9, 2023
@Roolli Roolli force-pushed the ram-load branch 2 times, most recently from e7db4ba to 949bfd6 Compare May 15, 2023 10:23
Copy link
Collaborator

@davidvincze davidvincze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the impact of the new test cases on the execution time?

sim/src/image.rs Outdated Show resolved Hide resolved
sim/src/image.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@davidvincze davidvincze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this patch stack.

.github/workflows/sim.yaml Outdated Show resolved Hide resolved
@Roolli
Copy link
Author

Roolli commented Jun 21, 2023

What's the impact of the new test cases on the execution time?

Insignificant, as the tests that are taking a long time aren't being ran.

Roland Mikhel added 3 commits June 28, 2023 08:44
If ram-load is being used with encryption and
the higher version image is loaded from the primary slot the
verification will fail as the image is always non-encrypted
and will produce an invalid hash. This fix puts encrypted images
into both slots to prevent this issue.

Signed-off-by: Roland Mikhel <roland.mikhel@arm.com>
Change-Id: I4ac9f332434a95d140c5572096b8a9161db2d217
Adds new test cases to various ram-load related logic.

Signed-off-by: Roland Mikhel <roland.mikhel@arm.com>
Change-Id: I3a0ca951b2c720be4e6fe2ed0e5d1830fcfb240c
Adds new test combinations to the CI to
test the ram-load feature more thoroughly.

Signed-off-by: Roland Mikhel <roland.mikhel@arm.com>
Change-Id: I56d6f74af55ed078947c092726160b123d36f67f
@davidvincze davidvincze merged commit 7ecffd4 into mcu-tools:main Jun 29, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sim Affects the simulator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants