sim: Add hw rollback protection tests #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roolli
force-pushed
the
hw-rollback-protection
branch
from
ee81332
to
02500a5
Compare
davidvincze
reviewed
Jun 15, 2023
Roolli
force-pushed
the
hw-rollback-protection
branch
from
02500a5
to
68c1c14
Compare
davidvincze
reviewed
Jun 21, 2023
Currently there's a compile error when building MCUboot with HW_ROLLBACK_PROT due to a comparison when decoding the security_cnt fih_int value. In the security_cnt.h it is stated that this value must be between 0 and UINT32_MAX so this cast would not cause any undefined behaviour. Signed-off-by: Roland Mikhel <roland.mikhel@arm.com> Change-Id: Iee158a31955ff43b73e67a0c08e7a086077b9eb5
Roolli
force-pushed
the
hw-rollback-protection
branch
from
68c1c14
to
132511d
Compare
added 3 commits
June 21, 2023 14:09
This commit adds simulator support to test the hw-rollback-protection feature which is using nv-counters. In the simulator they are stored in Rust to prevent any race conditions from happening due to the parallel execution of the tests. Signed-off-by: Roland Mikhel <roland.mikhel@arm.com> Change-Id: I445fc50615ed1f0c06e5933b16811c24d9d302fc
Signed-off-by: Roland Mikhel <roland.mikhel@arm.com> Change-Id: I3dee0baf27b8cae78b87135ea7447556b06fdefd
Signed-off-by: Roland Mikhel <roland.mikhel@arm.com> Change-Id: If636d9179c6f06d4bf7452b8eb4f07d3829cf2d7
Roolli
force-pushed
the
hw-rollback-protection
branch
from
132511d
to
29b6953
Compare
davidvincze
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds testing capabilities to the hw-rollback-protection feature of MCUboot. The non-volatile storage for the security counters is implemented on Rust's side due to the parallel nature of the tests. There is also a fix for a build error when comparing the security counter values during the simulator build.