boot_serial: fix misuse of 'matched' param from zcbor_map_decode_bulk() #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'matched' param in zcbor_map_decode_bulk() function is 'pointer to the counter of matched keys', not length of payload buffer. Fixes: fac2cab ("boot_serial: Add image state set/get") Signed-off-by: Piotr Dymacz <pepe2k@gmail.com>
nordicjm
approved these changes
Jun 29, 2023
carlescufi
approved these changes
Jul 4, 2023
|
@davidvincze @d3zd3z Could you please take a look and approve/merge if happy? |
d3zd3z
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
matchedparam inzcbor_map_decode_bulk()function ispointer to the counter of matched keys, not length of payload buffer. Reference: https://github.com/mcu-tools/mcuboot/blob/main/boot/boot_serial/src/zcbor_bulk.h#L96, fixes: fac2cab.