encryption: Improve Kconfig and key generation for zephyr, fix boot serial encrypted image support #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
force-pushed
the
encimprove
branch
5 times, most recently
from
5e18c8c
to
8bc0572
Compare
nordicjm
changed the title
nvlsianpu
reviewed
Aug 1, 2023
| @@ -256,8 +256,6 @@ Use the ``CONFIG_ENABLE_MGMT_PERUSER=y`` Kconfig option to enable the following | |||
|
|
|||
| Images uploaded by the serial recovery can be decrypted on the fly by using ECIES primitives described in the [ECIES encryption](encrypted_images.md#ecies-encryption) section. | |||
|
|
|||
| Enable support for this feature by using ``CONFIG_BOOT_SERIAL_ENCRYPT_EC256=y``. | |||
There was a problem hiding this comment.
Can you explain here How to use this feature with your changes?
There was a problem hiding this comment.
I might just remove this section since it doesn't really apply anymore, if encryption is enabled then encrypted images can be used, regardless of type of encryption.
There was a problem hiding this comment.
If this is mentioned in general readame - I'm fine with removal.
There was a problem hiding this comment.
Yes, page on encryption: https://docs.mcuboot.com/encrypted_images.html
nvlsianpu
added
area: core
nvlsianpu
approved these changes
Aug 2, 2023
|
@de-nordic I would merge this If you see no obstacles. |
de-nordic
approved these changes
Aug 7, 2023
d3zd3z
requested changes
Aug 7, 2023
Improves the Kconfig layout for encrypted image support and allows using key files instead of just using a pre-defined, insecure dummy key. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Fixes issues whereby encrypted images were not properly listed due to not treating them as encrypted, also removes a piece of wrong hack code that would never run as the primary slot cannot be encrypted. Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
Adds notes on fixes and changes related to encrypted image handling Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
d3zd3z
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the Kconfig layout for encrypted image support and allows using key files instead of just using a pre-defined, insecure dummy key.
Fixes #1753