Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot: zephyr: don't allow GPIO entrance in timeout based serial recovery #1801

Conversation

pepe2k
Copy link
Contributor

@pepe2k pepe2k commented Sep 7, 2023

If a timeout based serial recovery is selected, there is no point in keeping support for GPIO based entrance method. These two ways for entering serial recovery should be mutually exclusive, same as it's done in USB DFU based recovery (Kconfig symbols: BOOT_USB_DFU_GPIO and BOOT_USB_DFU_WAIT).

If a timeout based serial recovery is selected, there is no point in
keeping support for GPIO based entrance method. These two ways for
entering serial recovery should be mutually exclusive, same as it's
done in USB DFU based recovery (Kconfig symbols: 'BOOT_USB_DFU_GPIO'
and 'BOOT_USB_DFU_WAIT').

Signed-off-by: Piotr Dymacz <pepe2k@gmail.com>
@pepe2k
Copy link
Contributor Author

pepe2k commented Sep 7, 2023

As an alternative solution I can think of here, BOOT_SERIAL_ENTRANCE_GPIO and BOOT_SERIAL_WAIT_FOR_DFU could be moved into Kconfig choice group, in similar way as it's done with the USB DFU (entrance can be one of: none, GPIO, timeout).

@nordicjm
Copy link
Collaborator

nordicjm commented Sep 7, 2023

They're not mutually exclusive though, there is no reason both of these modes cannot be supported in a single image, that would be limiting a user's choice without a good reason.

@pepe2k
Copy link
Contributor Author

pepe2k commented Sep 7, 2023

They're not mutually exclusive though, there is no reason both of these modes cannot be supported in a single image, that would be limiting a user's choice without a good reason.

Hi @nordicjm, ok, is there any reason why it's different in case of USB DFU, timeout and GPIO based entrances aren't available at the same time?

@nordicjm
Copy link
Collaborator

nordicjm commented Sep 7, 2023

Have not really looked at USB DFU support other than when playing around with some devices and abandoning it in favor of serial recovery and have improved serial recovery a lot in the past year, no reason USB DFU can't be reworked to support both as well

@pepe2k pepe2k closed this Sep 7, 2023
@pepe2k pepe2k deleted the main__zephyr-no-gpio-entrance-in-timeout-based-recovery branch September 8, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants