Add some options to ptest to allow limit sets of tests to be run. #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a skeleton of a command line parser to the ptest utility. This will allow future changes to add additional options, such as listing and filtering the tests that are used. This adds a single subcommand `run`, which mimics the previous ptest behavior. Signed-off-by: David Brown <david.brown@linaro.org>
Allow the `--workflow` argument to override the workflow file that is used, with a reasonable default of the workflow used by CI. Signed-off-by: David Brown <david.brown@linaro.org>
The `list` command will show what tests are available. Signed-off-by: David Brown <david.brown@linaro.org>
The `--test` (`-t`) argument allows the caller to limit the tests that are invoked by ptest. The argument can be specified multiple times to run several tests. The numbers are based on the output of `--list`. Signed-off-by: David Brown <david.brown@linaro.org>
Adjust the printed numbers, as well as the values to `--test` so that the tests are numbered starting from 1 instead of zero. Signed-off-by: David Brown <david.brown@linaro.org>
The normal simulation test takes several hours to run on most machines. Allow a few very slow tests to be skipped by setting the environment variable `MCUBOOT_SKIP_SLOW_TESTS` to some value. For obvious reasons, this shouldn't be done if these power failure simulation tests are needed. With this change, on my desktop Linux machine, the test time with the skipping goes from about 2 hours, to around 5 minutes. Signed-off-by: David Brown <david.brown@linaro.org>
Signed-off-by: David Brown <david.brown@linaro.org>
|
@davidvincze Any chance on a review here? |
|
Thank you for this patch David, no comments from my side. |
davidvincze
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ptest command runs multiple tests, based on the
sim.yamlfile that CI uses. Enhance this command to support listing the tests that would be run, and selecting a subset of those tests.