Removed unnecessary if-statement #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
approved these changes
Apr 17, 2024
|
Commit needs to be signed off |
de-nordic
requested changes
Apr 17, 2024
Robpaa
force-pushed
the
fix-boot-serial-if
branch
2 times, most recently
from
cb26c2f
to
708dcb5
Compare
Robpaa
changed the title
If-statement checks if length is greater than some value right after a check if it is equal to the same value. This will never be true. Signed-off-by: Robert Paananen <robert@paananen.nu>
Robpaa
force-pushed
the
fix-boot-serial-if
branch
from
708dcb5
to
9a275d2
Compare
|
Struggling with getting the CI to accept my Signed-off, I might have mixed different emails when creating this commit. Hopefully it works now 😄 |
de-nordic
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unnecessary if-statement in boot_serial.c
Closes #1940